Update TaskCompletionSource constructor to use TaskCreationOptions.RunContinuationsAsynchronously#400
Closed
salgatbp wants to merge 1 commit intokurrent-io:masterfrom
Closed
Conversation
…nContinuationsAsynchronously
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates internal TaskCompletionSource<T> instantiations to use TaskCreationOptions.RunContinuationsAsynchronously to reduce the risk of deadlocks caused by inline/synchronous continuations in the KurrentDB client’s streaming read/append flows.
Changes:
- Use
RunContinuationsAsynchronouslyfor the read operation’sReadStatecompletion source. - Use
RunContinuationsAsynchronouslyfor the batch append usability signal and per-request completion sources.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/KurrentDB.Client/Streams/KurrentDBClient.Read.cs | Updates the ReadState TaskCompletionSource to run continuations asynchronously. |
| src/KurrentDB.Client/Streams/KurrentDBClient.Append.cs | Updates batch append TaskCompletionSource instances to run continuations asynchronously. |
Comments suppressed due to low confidence (1)
src/KurrentDB.Client/Streams/KurrentDBClient.Append.cs:249
completeis added to_pendingRequestsbefore any writes to the channel. If_channel.Writer.WriteAsync(...)later throwsChannelClosedException(or any other exception in this try block), this entry is never removed, which can leak_pendingRequestsentries on failure paths. Consider ensuring the correlationId is removed in the exception path (or only add the TCS after the request is successfully queued).
var complete = _pendingRequests.GetOrAdd(correlationId, new TaskCompletionSource<IWriteResult>(TaskCreationOptions.RunContinuationsAsynchronously));
try {
foreach (var appendRequest in GetRequests(events, options, correlationId))
await _channel.Writer.WriteAsync(appendRequest, cancellationToken).ConfigureAwait(false);
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| var correlationId = Uuid.NewUuid(); | ||
|
|
||
| var complete = _pendingRequests.GetOrAdd(correlationId, new TaskCompletionSource<IWriteResult>()); | ||
| var complete = _pendingRequests.GetOrAdd(correlationId, new TaskCompletionSource<IWriteResult>(TaskCreationOptions.RunContinuationsAsynchronously)); |
Contributor
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to avoid potential deadlocks due to synchronous continuations. More specifically, we're seeing a potential deadlock scenario in the KurrentDB client and are trying to narrow down potential causes.